Update IssueEvent ID field from int to long #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2060 +/- ##
==========================================
- Coverage 70.79% 67.06% -3.74%
==========================================
Files 538 538
Lines 14139 14139
==========================================
- Hits 10010 9482 -528
- Misses 4129 4657 +528
|
|
(the code coverage reduction is a little disconcerting, given that this was all 1:1 type/name changes) |
Yeah, I had a poke at the places it say were regressed but I can't spot anything I should be worried about 🤷♂ |
shiftkey
approved these changes
Jan 19, 2020
|
release_notes: changed |
This was referenced Feb 9, 2020
nickfloyd
added
Type: Bug
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #1979 and #2031 (stack overflow when attempting to retrieve events on issues due to large ID numbers) and replaces the seemingly-abandoned PR #2037.
In addition to changing the types of the relevant field and parameters, the names of the parameters have also been updated (from
numbertoeventId) to better reflect what's expected to be passed.